Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting up a helm tenant, a secret is created even if you set existingSecret. #1909

Closed
LemonDouble opened this issue Dec 15, 2023 · 0 comments · Fixed by #1910
Closed

Comments

@LemonDouble
Copy link
Contributor

LemonDouble commented Dec 15, 2023

I was trying to set accessKey, secretKey using an existingSecret,

However, even if I follow the settings in Values.yaml and set existingSecret.name, it does not use the existing secret, but creates a new secret.

Expected Behavior

when set existingSecret.name, the minio tenant don't make new secret, and use existing Secret.

Current Behavior

when set existingSecret.name, the minio tenant don't create new Secret.

Possible Solution

Fix incorrect indentation in values.yaml.

i make PR #1910

Steps to Reproduce (for bugs)

  1. create an secret.( contains config.env)
  2. set existingSecret.name for values.yaml
  3. launch cluster
  4. then new secret created

Context

This seems to have been committed with incorrect indentation in PR #1827.

Work has been done on existingSecret in PR #1663. and the actual code in tenant-configuration.yaml is referencing Values.secrets.existingSecret.

This appears to be an issue with the documentation update.

Regression

no

Your Environment

  • Version used (minio-operator): 5.0.11
  • Environment name and version (e.g. kubernetes v1.17.2): k3s 1.27.7+k3s2
  • Operating System and version (uname -a): Linux control01 5.15.0-1044-raspi Dynamic PVC using storageclass fails because name is nill #47-Ubuntu SMP PREEMPT Tue Nov 21 11:33:46 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant