Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumption of Bootstrap and Jquery #5

Open
slinkymanbyday opened this issue May 21, 2023 · 3 comments
Open

Assumption of Bootstrap and Jquery #5

slinkymanbyday opened this issue May 21, 2023 · 3 comments

Comments

@slinkymanbyday
Copy link

The included templates assume bootstrap and jquery are loaded from the projects base templates.
These should probably be either included in the projects static files, or mentioned in the documentation.

@mkalioby
Copy link
Owner

mkalioby commented May 21, 2023

Great point. I'll work on adding them to the library but the templates can be overriden by the user.

@kakulukia
Copy link

i just also stumbled over this issue and i agree: bootstrap and jquery should be loaded in the passkey template.

But even loading jQuery myself i get "Uncaught TypeError: $(...).modal is not a function" .. not sure if i have the right jquery version either (i used this one https://code.jquery.com/jquery-3.7.0.min.js)

@rafaelurben
Copy link

Note: The requirement for jQuery and Bootstrap has been added to the documentation a long time ago. Also, #27 would remove the jQuery dependency completely.

I think this Issue may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants