From 6eef1abedbf81015377dd27067b16291c276b1e5 Mon Sep 17 00:00:00 2001 From: Mathias Lafeldt Date: Mon, 20 Jan 2025 16:40:58 +0100 Subject: [PATCH] Add comments --- build.zig | 1 + quack_extension.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/build.zig b/build.zig index 241f742..c40d0a4 100644 --- a/build.zig +++ b/build.zig @@ -72,6 +72,7 @@ pub fn build(b: *std.Build) !void { const filename = b.fmt("{s}.duckdb_extension", .{ext.name}); ext.install_name = b.fmt("@rpath/{s}", .{filename}); // macOS only + // TODO: Rewrite the metadata script in Zig const output = out: { const cmd = b.addSystemCommand(&.{ "python3", metadata_script }); cmd.addArgs(&.{ "--extension-name", ext.name }); diff --git a/quack_extension.c b/quack_extension.c index 9dc3b35..6abb9df 100644 --- a/quack_extension.c +++ b/quack_extension.c @@ -1,5 +1,5 @@ -#include -#include // memcpy +#include // Only available in DuckDB 1.1.2 and later +#include // memcpy DUCKDB_EXTENSION_EXTERN