Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow children for Dialog.Button #138

Open
nephix opened this issue Apr 20, 2022 · 1 comment
Open

Allow children for Dialog.Button #138

nephix opened this issue Apr 20, 2022 · 1 comment
Labels
question Further information is requested

Comments

@nephix
Copy link

nephix commented Apr 20, 2022

Ask your Question

Does it make sense to extend <Dialog.Button /> to render children? My use case is that I e.g. display a confirmation dialog. Once the user presses "Ok" I want to disable the button (already possible) and display a loading indicator:

<Dialog.Button disabled={loading}>
   {loading && <LoadingIndicator />}
   <Text>Confirm</Text>
</Dialog.Button>

with the current implementation via label this is not possible.

@nephix nephix added the question Further information is requested label Apr 20, 2022
@pierroo
Copy link

pierroo commented Sep 6, 2024

2 years later but, would it be possible?

those buttons are the only part we can't customize; even the fact that the label are forced uppercase can't be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants