Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation bug in SetLevelRequest #167

Closed
witchof0x20 opened this issue Feb 15, 2025 · 0 comments · Fixed by #172
Closed

Documentation bug in SetLevelRequest #167

witchof0x20 opened this issue Feb 15, 2025 · 0 comments · Fixed by #172
Labels
bug Something isn't working

Comments

@witchof0x20
Copy link

witchof0x20 commented Feb 15, 2025 •
edited
Loading

Describe the bug
https://github.com/modelcontextprotocol/specification/blob/main/schema/2024-11-05/schema.json#L1078
states that the method for server->client logging is notifications/message
https://github.com/modelcontextprotocol/specification/blob/main/schema/2024-11-05/schema.json#L1879C29-L1880C26
states

The level of logging that the client wants to receive from the server. The server should send all logs at this level and higher (i.e., more severe) to the client as notifications/logging/message.

For a sanity check, the documentation page says notifications/message is correct
https://spec.modelcontextprotocol.io/specification/2024-11-05/server/utilities/logging/
@witchof0x20 witchof0x20 added the bug Something isn't working label Feb 15, 2025
dsp-ant added a commit that referenced this issue Feb 21, 2025
@dsp-ant
fix: documentation bug in SetLevelRequest
dfc8848 
The description SetLevelRequest mention that logging notification
to be `notifications/logging/message` while in fact it is
`notifications/message`.

Github-Issue: #167
@dsp-ant dsp-ant mentioned this issue Feb 21, 2025
Merged
@dsp-ant dsp-ant linked a pull request Feb 21, 2025 that will close this issue
fix: documentation bug in SetLevelRequest #172
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: documentation bug in SetLevelRequest modelcontextprotocol/specification
1 participant
@witchof0x20