From 4891e81fd5cfb341638832e0986ada466c0ea89d Mon Sep 17 00:00:00 2001 From: tmpolaczyk <44604217+tmpolaczyk@users.noreply.github.com> Date: Tue, 12 Dec 2023 17:59:43 +0100 Subject: [PATCH] Fix features not being passed to cargo-build template (#2486) * Fix features not being passed to cargo-build template * Remove evm-tracing feature from coverage job * Remove build-features action --- .../workflow-templates/cargo-build/action.yml | 4 ++-- .github/workflows/build.yml | 19 ------------------- .github/workflows/coverage.yml | 2 -- 3 files changed, 2 insertions(+), 23 deletions(-) diff --git a/.github/workflow-templates/cargo-build/action.yml b/.github/workflow-templates/cargo-build/action.yml index c78c953102..94b111db33 100644 --- a/.github/workflow-templates/cargo-build/action.yml +++ b/.github/workflow-templates/cargo-build/action.yml @@ -42,8 +42,8 @@ runs: run: | env params=" --locked --release -p moonbeam" - if [ -n "${{ github.event.inputs.features }}" ]; then - params="$params --features ${{ github.event.inputs.features }}" + if [ -n "${{ inputs.features }}" ]; then + params="$params --features ${{ inputs.features }}" fi echo "cargo build $params" cargo build $params diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b46ec52bf7..d53101eaa4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -307,25 +307,6 @@ jobs: name: moonbeam path: build - build-features: - runs-on: - labels: bare-metal - needs: ["set-tags"] - steps: - - name: Checkout - uses: actions/checkout@v3 - with: - ref: ${{ needs.set-tags.outputs.git_ref }} - - name: Cargo build - uses: ./.github/workflow-templates/cargo-build - with: - features: "try-runtime" - - name: Upload binary - uses: actions/upload-artifact@v3.1.2 - with: - name: moonbeam-features - path: build - rust-test: runs-on: labels: bare-metal diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 38bb65ea10..e8c41059ae 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -116,8 +116,6 @@ jobs: run: rustup component add llvm-tools-preview - name: Cargo build uses: ./.github/workflow-templates/cargo-build - with: - features: evm-tracing - name: Enable coverage gathering run: | # Enable coverage when running tests