From 4e5478de1c0e10d12bc5b1aeac46f2fcf805e07f Mon Sep 17 00:00:00 2001
From: Steve Degosserie <723552+stiiifff@users.noreply.github.com>
Date: Fri, 24 Jan 2025 17:08:40 +0100
Subject: [PATCH] Release process tweaks (#3147)

* Release process tweaks

* add glibc check

---------

Co-authored-by: Rodrigo Quelhas <rodrigo_quelhas@outlook.pt>
---
 .github/workflows/subxt-diff.yml            | 2 +-
 tools/github/print-client-release-issue.ts  | 5 +++--
 tools/github/print-runtime-release-issue.ts | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/subxt-diff.yml b/.github/workflows/subxt-diff.yml
index 39c6725ac5..d229ca4ac4 100644
--- a/.github/workflows/subxt-diff.yml
+++ b/.github/workflows/subxt-diff.yml
@@ -138,6 +138,6 @@ jobs:
           branch: "runtime-diff-${{ github.event.inputs.spec_version }}"
           commit-message: "runtime diff: v0.${{ github.event.inputs.spec_version }}.0"
           draft: true
-          title: "Notorize runtime upgrade differences: runtime-${{ github.event.inputs.spec_version }}"
+          title: "Notarize runtime upgrade differences: runtime-${{ github.event.inputs.spec_version }}"
           reviewers: "RomarQ,stiiifff"
           labels: "B0-silent,D2-notlive"
diff --git a/tools/github/print-client-release-issue.ts b/tools/github/print-client-release-issue.ts
index a06e68eb66..b53aa08124 100644
--- a/tools/github/print-client-release-issue.ts
+++ b/tools/github/print-client-release-issue.ts
@@ -46,11 +46,12 @@ async function main() {
 \`\`\`
 (matching your ${newVersion} tag) and increase the config version + 1.
 - [ ] Test the new client on stagenet (moonsama/moonlama).
+- [ ] Check glibc version (eg. objdump -T <binary> | grep GLIBC | sed 's/.*GLIBC_\\([.0-9]*\).*/\\1/g' | sort -Vu)
 - [ ] Publish the client release draft.
 - [ ] When everything is ok, publish the new docker image: start github action Publish Docker
-with ${newVersion}.
+with ${newVersion} (!!! NOT before fully tested on stagenet !!!).
 - [ ] Publish the new tracing image: on repo moonbeam-runtime-overrides, start github action
-Publish Docker with ${newVersion} and master.
+Publish Docker with ${newVersion} and master (!!! NOT before fully tested on stagenet !!!).
 `;
 
   // Detect if it's a major release or hotfix
diff --git a/tools/github/print-runtime-release-issue.ts b/tools/github/print-runtime-release-issue.ts
index 743f9e9211..797839059d 100644
--- a/tools/github/print-runtime-release-issue.ts
+++ b/tools/github/print-runtime-release-issue.ts
@@ -46,7 +46,8 @@ with runtime-${previousVersion} => runtime-${newVersion}
 - [ ] Upgrade stagenet
 - [ ] Create new tracing image for partners: start the github action Publish Docker
 with ${lastClientVersion} and master
-- [ ] Upgrade alphanet
+- [ ] Release comms
+- [ ] Upgrade alphanet (!!! NOT before release comms / tracing images !!!)
 - [ ] When everything is ok, publish the draft release
   `;