Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mixer become an independent crate #35

Closed
ChunMinChang opened this issue Dec 20, 2019 · 4 comments
Closed

Make mixer become an independent crate #35

ChunMinChang opened this issue Dec 20, 2019 · 4 comments
Assignees
@ChunMinChang

Comments

@ChunMinChang
Copy link
Member

ChunMinChang commented Dec 20, 2019 •
edited
Loading

The mixer crate is introduced in #23 to solve the BMO 1468381. The new mixer is able to mix audio from any input layout to any output layout.

The BMO 1368938: mixer only support pre-defined layout on Windows, is probably the same problem of BMO 1468381 so it is likely to be solved by adopting the new mixer on Windows.

Therefore, it's better to make the new mixer crate as an independent crate that can be used to other platforms and make it as a successor of cubeb_mixer.
@ChunMinChang ChunMinChang self-assigned this Dec 20, 2019
@ChunMinChang ChunMinChang changed the title Make mixer an independent crate Make mixer become an independent crate Dec 30, 2019
@ChunMinChang ChunMinChang mentioned this issue Dec 30, 2019
Merged
@ChunMinChang
Copy link
Member Author

The mixer crate is moved to https://github.com/ChunMinChang/audio-mixer now

@ChunMinChang
Copy link
Member Author

Soved by #37

@Squall-Leonhart Squall-Leonhart mentioned this issue Oct 2, 2021
Open
@Squall-Leonhart
Copy link

Sad news Chun, looks like this broke the rear channels on XFI with enhancements turned on.

@ChunMinChang
Copy link
Member Author

ChunMinChang commented Oct 2, 2021 •
edited
Loading

Sad news Chun, looks like this broke the rear channels on XFI with enhancements turned on.

I don't think I understand the reasoning. Could you describe why you suspect this update is the cause?

It seems the problem issued in mozilla/cubeb#661 is on Windows, while the mixer crate is only used on macOS now. The mixer-crate hasn't been imported into Windows yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChunMinChang ChunMinChang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Squall-Leonhart @ChunMinChang