Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strum #2439

Open
larseggert opened this issue Feb 12, 2025 · 0 comments · May be fixed by #2440
Open

Use strum #2439

larseggert opened this issue Feb 12, 2025 · 0 comments · May be fixed by #2440

Comments

@larseggert
Copy link
Collaborator

There is FromRepr in strum_macros, which is already a dependency for Firefox. If we want to use this, I suggest a separate PR, since it will probably be useful for other enums.

Originally posted by @larseggert in #2438 (comment)
larseggert added a commit to larseggert/neqo that referenced this issue Feb 12, 2025
@larseggert
chore: Use strum macros
b886913 
And remove some boilerplate code.

Fixes mozilla#2439
@larseggert larseggert linked a pull request Feb 12, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use strum macros larseggert/neqo
1 participant
@larseggert