Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax warning from __init__.py: assert file != "" is not None #166

Open
juliangilbey opened this issue May 31, 2022 · 0 comments
Open

Syntax warning from __init__.py: assert file != "" is not None #166

juliangilbey opened this issue May 31, 2022 · 0 comments

Comments

@juliangilbey
Copy link

Pweave/pweave/__init__.py

Line 47 in 45b56ec

assert file != "" is not None, "No input specified"

raises the followng warning:

SyntaxWarning: "is not" with a literal. Did you mean "!="?
  assert file != "" is not None, "No input specified"

The code as written means: assert (file != "") and ("" is not None), which is clearly not what is wanted; perhaps it should be assert (file != "") and (file is not None) instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juliangilbey