Best place to write custom directive implementation?

[taneba]

Thank you all for awesome work, I have a question about writing custom directive.

When writing my own envelop plugin, it seems we could write custom directive logic in onExectute.onResolverCalled and onSchemaChange as well.
Which is the preferred place to write?

[n1ru4l]

@taneba Could you share what kind of directive you try to build? Depending on that the answer might differ, there is probably no "one suits all" solution.

[n1ru4l]

For this use-case that looks totally fine with me and onSchemaChange seems like the right place to do it! In case your used schema is changed frequently you could furthermore utilize a WeakMap for caching the schema transform.

[taneba]

@n1ru4l
Thanks, good to hear that! Is it because it needs schema override which can not be done in onExecute, right?

In case your used schema is changed frequently you could furthermore utilize a WeakMap for caching the schema transform

Yeah, I've learned that trick from useResponseCache plugin and I'm using it :)

[n1ru4l]

@taneba I think this could be a great example for our documentation - Would you mind sending a PR with a short guide on how to add custom schema directive logic to your schema with envelop?

[taneba]

@n1ru4l
Of course I'd love to! IMO isOwner directive is a bit complex, so how about uppercase directive, which is usually shown in a custom directive example?

[n1ru4l]

IMHO an uppercase directive should instead be a field argument 😓 . It is really hard to find legit use-cases where a schema directive actually makes sense 🤔