build(people): update ilc-sdk and webpack #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-nc
requested review from
m2broth,
blackrabbit99,
b1ff,
yehor-manzhula and
harnyk
stas-nc
force-pushed
the
chore/webpack
branch
from
e46ff23 to
5a39c16
Compare
| "@babel/plugin-syntax-dynamic-import", | ||
| ] | ||
| "presets": ["@babel/preset-env", "@babel/preset-react"], | ||
| "plugins": [["@babel/plugin-proposal-decorators", { "version": "legacy" }]] |
There was a problem hiding this comment.
Is it hard to migrate to newer versions ?
There was a problem hiding this comment.
We are using here some abandoned package named AsyncDecorator and such syntax (without brackes) requires { "version": "legacy" }
Also, this project is not migrated completely:
- react-router is not the latest version (seems like incompatibility with ilc-adapter-react)
- react is not the latest version (18)
- The react-css-modules package is also deprecated but requires more rewrite of the app
It makes sense to adapt to the newer version of the mentioned packages and then come back here again.
yehor-manzhula
approved these changes
Jan 10, 2025
wRLSS
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested new ilc-sdk