-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 5x version. #31
Comments
Hey this would be great! I’d be happy to upgrade and support the new styles. Thanks for all the work on your libraries. Would you be open to submitting a PR for the Swift side? I can integrate any changes on the React Native side. |
Also if you need any help on my end let me know and I can assist. |
Sure. Let me know what you need and I ready to do or explain |
The changes would be made in the |
Hey @ivanvorobei, any shot we could fix #39 on your library? Currently the text gets pretty cut off. Let me know if you need any suggestions. I think it should allow a wider toast for long text, as well as supporting multline text. |
Hi! I see developer put there so long text, but I think main concept is use there 1-2 words maximum. Maybe, I can do it optional, but with long text it looks ugly |
Yeah, but I’m thinking it’s go to the developer. Ideally you could set:
|
In this case we missing native UI which apple did. Idea was mimicrate to original one |
I see, yeah that's a fair point. I think many users of my library want a general Toast component which can also look like in-app notifications from apps like Instagram/Twitter. But I understand if that's not what you want for yours. |
I think can add smth optional value for this case |
Thank you! |
For new version added more styles. Good to integrate it as well.
If need any help let me know I happy to assist.
The text was updated successfully, but these errors were encountered: