-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[THANKS] This is not an issue #135
Comments
Glad it's useful 😎 |
This comment has been minimized.
This comment has been minimized.
And I want to say that forcing RN apps to install expo for simple skeleton is madness. Just threw this package away from the code [to the bin] and finally the app started to work properly after upgrading RN and react-native-navigation. |
You have the option to install React Native Navigation has nothing to do with Moti. This is an animations library. Typically when someone encounters a problem on an open source project, they take the time to open an issue, reproduce it, and describe a desired solution. I suggest you follow this etiquette in the future. |
@nandorojo It forces to install expo for skeleton, that's what I said. If your package is not compatible with popular navigation library, and probably other native libraries as well, this is an issue. And current issue is not typical, it "is not an issue", so I just shared my thoughts as well. As for the actual issue - it already exists. |
Moti is a JS-only library whose only native peer dependencies are Reanimated and React Native Gesture Handler. The skeleton’s only added peer dependency is the gradient. So Moti plays no role in the compatibility.
If React Native Navigation isn’t compatible with Expo modules, then it is on that library and Expo to fix it. It’s not Moti’s job to keep up with every regression in unrelated packages.
So what would you prefer then? A skeleton without a gradient? Or no skeleton at all? Expo packages provide a high level of stability and maintenance, so it’s an easy choice for a (rare) native library. |
Skeleton could be easily done with any other gradient package like react-native-linear-gradient or even svg, without need of adding one of the heaviest native dependency Example - https://www.npmjs.com/package/react-native-skeleton-placeholder |
You're free to use that library then or build your own. |
Yeah, that's what I did. |
Well, that's fake news, it's not standalone, it requires expo-modules-core |
Moti's skeleton now supports |
I think @nandorojo did an awesome job! I agree with OP. I love working with this library! ❤️
It is truly astonishing how @gen1lee perceives themselves as entitled to casually throw around disrespectful nonsense. As mentioned earlier, the only necessary dependencies are react-native-reanimated and react-native-gesture-handler. There is no involvement of native code. Considering that this ticket is a year old, I sincerely hope you have learned from this experience. Behavior like this is precisely the reasons why there are still shortcomings in the community around open source projects. |
I just came here to say
f*ck yeah
. This package is amazing and I've been crying out for a framer-motion alike on React Native for ages.So, thank you! Feel free to close this.
The text was updated successfully, but these errors were encountered: