Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using skeleton as loader, screen stucks and flickers #344

Open
1 of 3 tasks
Nadimkhan120 opened this issue May 14, 2024 · 8 comments
Open
1 of 3 tasks

When using skeleton as loader, screen stucks and flickers #344

Nadimkhan120 opened this issue May 14, 2024 · 8 comments

Comments

@Nadimkhan120
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Do you want this issue prioritized?

  • Yes, I have sponsored
  • Not urgent

Current Behavior

  1. add a skeleton in one screen as loader
  2. navigate from another screen to the screen having loader
  3. screen stucks and there is a flicker

Expected Behavior

when using skeleton as loader screen should not stuck, it should work fine

Steps To Reproduce

  1. add a skeleton in one screen as loader
  2. navigate from another screen to the screen having loader
  3. screen stucks and there is a flicker
  4. if i remove skeleton, it will work fine

Versions

- Moti:0.28.1
- Reanimated:3.11.0
- React Native:0.74.1

Screenshots

WhatsApp.Video.2024-05-15.at.12.16.00.AM.mp4
WhatsApp.Video.2024-05-15.at.12.17.45.AM.mp4

Reproduction

https://github.com/enzomanuelmangano/animate-with-reanimated/tree/main/18-skeleton-animation

@adamhari
Copy link

adamhari commented May 14, 2024

I'm experiencing something similar after upgrading from Expo 50 --> 51 where, after navigating to a screen that initially has a Skeleton with show={true} that later becomes show={false}, the Skeleton component continues to overlay it's children even after the show property is false.

This seems to be an Android issue, or at least I haven't been able to reproduce it on iOS or web, but that might have more to do with the performance characteristics of my Android device than it does the platform.

@Nadimkhan120
Copy link
Author

@adamhari yes its on android.

@Bialson
Copy link

Bialson commented Jul 5, 2024

I have similar problem to that. When I wrap <Image/> component with skeleton, there are strange flicker, image re-render and the height of layout is changing so that's why flicker appears.

@andrewchester1
Copy link

I am noticing this same issue. When navigating to a new tab for the initial render, the screen gets stuck. I have tried upgrading everything, and this still a issue.

@Devdannnny
Copy link

I experienced the same issue, and it took me a couple of hours to figure out that it was from Moti's skeleton component. Everything looks good after disabling the skeleton.

@nandorojo
Copy link
Owner

And it's only on Android?

@Nadimkhan120
Copy link
Author

Nadimkhan120 commented Oct 1, 2024 via email

@alantoa
Copy link
Contributor

alantoa commented Oct 1, 2024

hey @Nadimkhan120, can you create a reproduction example? I clicked the reproduction example that you sent, but that example doesn't exist.

and I just tested it on Android, it works well for me.

"moti": "0.29.0",
"react-native-reanimated": "3.12.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants