Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomness #14

Open
Deleplace opened this issue Feb 24, 2022 · 1 comment
Open

Randomness #14

Deleplace opened this issue Feb 24, 2022 · 1 comment

Comments

@Deleplace
Copy link
Contributor

Hello, thank you for the nice library.

It seems that it is used in the wild to generate catchy identifiers e.g. "my-collection/bikes/elegant-green-coat" but also sometimes to generate easy to remember passwords. How exactly the library will be used is not fully under the control of the library author. However, there is an actionable mitigation to avoid to the users the "footgun" of inadvertently opening a security hole: use crypto.getRandomValues() (instead of Math.random()).

Would you like me to open a PR?

@nas5w
Copy link
Owner

nas5w commented Feb 26, 2022

@Deleplace yes, that's a great idea. Would love to see a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants