Slavas/bm inject tx #12899
Slavas/bm inject tx #12899
Conversation
ssavenko-near
force-pushed
the
slavas/bm-inject-tx
branch
from
d31c1bd to
44ec8e2
Compare
ssavenko-near
force-pushed
the
slavas/bm-inject-tx
branch
from
6b29970 to
468f01c
Compare
ssavenko-near
force-pushed
the
slavas/bm-inject-tx
branch
from
468f01c to
a73bbb7
Compare
There was a problem hiding this comment.
This will need to be merged/de-duplicated with synth-bm once that makes it into the workspace
| tracing::warn!(target: "transaction-generator", "failed to update the transactions validity range"); | ||
| } | ||
| } | ||
| // _ = &mut rx => { |
There was a problem hiding this comment.
Appears to be triggered by moving tx. Did not figure out yet how to work-around it. Anyway we do not have stop() yet.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12899 +/- ##
==========================================
- Coverage 70.54% 70.46% -0.09%
==========================================
Files 851 854 +3
Lines 174914 175104 +190
Branches 174914 175104 +190
==========================================
- Hits 123395 123384 -11
- Misses 46397 46595 +198
- Partials 5122 5125 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| Self { id, public_key: secret_key.public_key(), secret_key, nonce } | ||
| } | ||
|
|
||
| pub fn from_file(path: &Path) -> anyhow::Result<Account> { |
There was a problem hiding this comment.
Can this function not just panic? If it is failing then that means we will probably fail to start the application. I imagine that there isn't much that can be done [from within the application] if this fails. I am not a fan of unnecessary error passing and handling in relatively straightforward cli applications.
There was a problem hiding this comment.
further would extend this comment to the rest of the PR.
Also please do not invest time making changes to address this review yet till we have alignment on the overall approach.
No description provided.