Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State snapshotting doesn't quite work with forks #12919

Open
marcelo-gonzalez opened this issue Feb 12, 2025 · 0 comments
Open

State snapshotting doesn't quite work with forks #12919

marcelo-gonzalez opened this issue Feb 12, 2025 · 0 comments

Comments

@marcelo-gonzalez
Copy link
Contributor

If there's a fork at the place where we want to take a state snapshot, there could be an issue where the wrong snapshot is taken. #12912 fixed the fact that the result will be an actually inconsistent state, where unwanted snapshots might not be created, and wanted snapshots might not be created correctly. But there remains an issue where we prioritize the last snapshot request made to the state snapshot actor. But does the last request correspond to the block that will eventually become final? If not, then we might end up with the wrong state snapshot. So, we should fix that, possibly by delaying snapshot creation until the snapshot hash is final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant