Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable custom procedure check by default #1431

Open
umuzammil opened this issue Feb 27, 2020 · 3 comments
Open

Disable custom procedure check by default #1431

umuzammil opened this issue Feb 27, 2020 · 3 comments

Comments

@umuzammil
Copy link

APOC custom procedures feature periodically checks for updated custom procedures. This process e.g. does a call to db.clearQueryCaches.

Perhaps we can re-evaluate if we really need to do this and/or be if we should switch off this feature based on a config option for users that don't use custom cypher procedures.

We don't get any flag set e.g. in cluster when procedures do change. Maybe we could store a int number in systemdb and increment that upon every change to a cypher procedure. All cluster members check if that sequence number has changed if so, they update themselves.

The periodic check can perhaps be explicitly enabled via a config option.

@conker84
Copy link
Collaborator

As agreed with @umuzammil and the customer the issue is fixed in the last APOC release.
Feel free to reopen if you need

@umuzammil
Copy link
Author

thanks @conker84 .. the issue wasn't encountered in APOC 4.0.0.4, however the particular request is to re-evaluate if we should switch off custom procedure checks upon startup, by default or based on a config option for users that don't use custom cypher procedures.

@umuzammil
Copy link
Author

Hello,

Please re-open this, since the aim here is to re-evaluate if we really need to run custom procedure checks and/or be if we should switch off this feature based on a config option for users that don't use custom cypher procedures.

We don't get any flag set e.g. in cluster when procedures do change. Maybe we could store a int number in systemdb and increment that upon every change to a cypher procedure. All cluster members check if that sequence number has changed if so, they update themselves.

The periodic check can perhaps be explicitly enabled via a config option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants