perf: Switch deprecated parser querystring for fast-querystring #14677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 38450cb8-a4f4-4360-852f-b9183c3e5386Details
💛 - Coveralls |
This was a mistake in the docs and is being fixed. If you look at the source code it's clear they actually use |
|
This has now been fixed on the Fastify side (fastify/fastify#5993). Let's merge this if you're happy with it. @kamilmysliwiec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be considered. The performance gains are not negligible. Additionally, find-my-way and Fastify use it by default, so there's no reason to regress on this for the adapter.
The
querystringis also absolutely deprecated with the last feature commit from 2018 (it seems). @kamilmysliwiecRelated to #10248.