-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap charts in Netdata #265
Comments
This is great! You have to think of 2 additional issues:
|
@ktsaou thanks for the inputs. please see my comments below:
will specify this on the requirements above
For the old agent dashboard will open a issue on For the data collectors we probably need inputs from @ilyam8 and/or @thiagoftsm |
@ktsaou I mentioned "will add it" not that I had already added it 😅 |
@hugovalente-pm when we create charts, we give as argument the chart type, so we will need to change the collectors to send I suggest we sync cloud and agent dashboard for we release the new feature together. I think we can give a bad user experience if they see on cloud the |
@thiagoftsm unfortunately the agent shipped dashboard will stay behind. The agent will show We are working on a feature to mark the agent dashboard as We are also investigating a way of bringing the cloud dashboard on the agent, without actually refactoring it. We will see if that works somehow. For the moment, let the agent shipped dashboard stay behind. We will deal with this later. |
Thanks @ktsaou, I did not know all these details. @hugovalente-pm I suggest we schedule a meeting to understand better how we can address these different behaviors. Is the cloud storing in its own database the user preferences for charts? If it is doing this, we can give to you a list of charts that will use heatmaps by default. |
A user can change the type of a chart, but the default is still controlled by the data collector. So, until we move this setting away from the collector, it is the only place to do it. This means that the plugins.d protocol, and netdata internal
Everything that uses time buckets should be turned by default to There are a few collectors, like the Generally we should use
What do you mean? which behaviors? |
thanks @thiagoftsm for all the details, as @ktsaou said, we will have for now the Agent dashboard falling back to to summarise behaviour:
at Netdata Cloud, for any chart, a user can override the "suggested" chart type. on Overview and Single Node view this is currently only stored for the present user session, not stored as user preferences. on Custom Dashboards users can define the chart type and this will be saved as part of the definition of the Custom Dashboard to try to summarize what is needed for this feature, and in order to open respective tickets on other repos, we have:
|
I have the concern we store @ktsaou last time I talked with our designer I was informed that we could not change |
The colors can be changed even via
In JS there a color array per dashboard theme (white, dark) for all chart types. Just one for all of them.
I don't get this. What is "internal" in this statement? The agent?
Still I don't get. How a simple flag can impact ACLK? Today charts define themselves as
This is totally irrelevant. Even the old dashboard has to map the new chart type to an existing one (
They are here. Ask what you need to know. Avoid meetings please. |
I made many updates to my comment above. So please refresh. |
I agree, but the old designer said we have a color scheme for dark theme and another completely different for the white theme, so we could not only change the color. This was the motive I made that issue we closed after to create this.
The ACLK change a lot, probably I am having in my mind the first scheme that we made. Unless I am wrong, cloud was using
All right. We will do. 🤝 @hugovalente-pm are we already moving ahead with the two first bullets from this comment? Are we going to convert this issue to epic and create an issue for each one of the bullets? |
Anyway, he was wrong. We can do whatever we want with colors. |
@thiagoftsm this is the issue for Cloud FE (just noticed now that I had forgotten to put the label you mention about "convert this issue to epic", what would be the difference? Btw, there is main umbrella issue on netdata/product#1795 |
This is the way I work with @cpipilas, when we have different bullets we convert the issue for epic and after this we create a new issue for each one of the bullets. This way we can monitor the progress step-by-step. If you are not working like this, no problem I can adapt myself and write the requirements for front end here. |
got it @thiagoftsm , we can convert this to an EPIC if it makes easier for tracking |
@novykh please also add this on your list for review to see if details are ok to push to FE backlog |
Charts that could be heatmaps:
|
we agreed to try to start this task this week, considering this comment as the summary of the bullets that we will need some work
@TonyPath for Cloud BE there are these two bullets that we will need some work
@thiagoftsm for Agent we have the tickets that you created already but @ktsaou had also mentioned these below, do we need a ticket for those?
@DShreve2 this is the ticket that Tina had created in the past netdata/learn#937 |
Hello @hugovalente-pm , I think it will be better for the product team to monitor the tasks if we have tickets for each one of the plugins you wrote. This will also help us to split work between developers. Best regards! |
thanks @thiagoftsm I hadn't found those tickets hence my question :) I've moved the previous ones you created, which were under
to measure expectations, the heatmap |
@novykh, on a discussion with @amalkov it seemed to make sense for this one to be @MichaelGamel's next task |
There is an ongoing integration with uPlot library on charts repo. This library has a heatmap chart type. |
ok, cool @novykh please share once you have some more insights into that |
@ktsaou from my understanding the work on the agent will only be done once we have the Cloud UI as the Agent dashboard, right? example: |
Goal
The need come for the representation of latency charts which now are rendered as a stacked chart like this:
In the above charts, there are buckets of latencies as dimensions. These buckets are hard-coded in the data collector. This is a real example of a data query:
json payload for latency filesystem.ext4_write_latency chart
We need to render these data in a different way, to make it better for users see a heatmap of the latencies. For example, this is what Grafana is doing:
In the above chart:
min = 0
, whilemax = 0.38
.The tooltip of the chart on Grafana has a small histogram, showing all the value of all dimensions for a given time (x-axis). In our case, we could keep the tooltip we already have:
This new type of charts should be available on our Netdata Cloud charts for any chart and the above logic should apply as well:
THIS IS FOR NETDATA CLOUD
Agent dashboard will fallback to stacked charts.
Tasks to complete
FE
Cloud BE
Netdata Agent
charttype
of the eBPF plugin charts to heatmap netdata#12925Documentation
The text was updated successfully, but these errors were encountered: