Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Regressions in share dialog with windows 11 native style #7847

Open
4 of 8 tasks
mgallien opened this issue Feb 12, 2025 · 1 comment · May be fixed by #7854
Open
4 of 8 tasks

[Bug]: Regressions in share dialog with windows 11 native style #7847

mgallien opened this issue Feb 12, 2025 · 1 comment · May be fixed by #7854
Assignees

Comments

@mgallien
Copy link
Collaborator

⚠️ Before submitting, please verify the following: ⚠️

Bug description

If you open the share dialog on windows 11, some controls are too small and cannot be clicked.
For example setting a comment for the recipient of a share has several issues:

Image

The placeholder text appears as a real text that you manually need to delete.
The internal button that you have to use to validate the input is not visible (while present and you can click on it)

Other components have similar issues.

Steps to reproduce

  1. Open the share dialog on a file
  2. Create a share and test all existing options

Expected behavior

UI is perfect with good sizing

Which files are affected by this bug

n/a

Operating system

Windows

Which version of the operating system you are running.

Windows 11

Package

Official Windows MSI

Nextcloud Server version

30.0.5

Nextcloud Desktop Client version

3.16.0-rc1

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

Additional info

No response

@nilsding
Copy link
Member

the icons aren't dark-mode ready either... will take care of that too

nilsding added a commit that referenced this issue Feb 13, 2025
it's already styled properly as it's part of Qt Quick Controls, **and**
it allows for a placeholder text!

also changed the logic for displaying the text field a bit ...

Fixes #7847

Signed-off-by: Jyrki Gadinger <[email protected]>
@nilsding nilsding linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants