From 39a05f8ac6c73564af7cff19e0fbd430c8ce1942 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Kn=C3=B6ppler?=
 <6317548+theCalcaholic@users.noreply.github.com>
Date: Wed, 6 Nov 2024 17:43:33 +0100
Subject: [PATCH] ncp-update-nc: Use oneshot service type with start and stop
 timeout for systemd-run
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Tobias Knöppler <6317548+theCalcaholic@users.noreply.github.com>
---
 bin/ncp-update-nc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bin/ncp-update-nc b/bin/ncp-update-nc
index 4ae12989e..347868089 100755
--- a/bin/ncp-update-nc
+++ b/bin/ncp-update-nc
@@ -53,7 +53,8 @@ then
 fi
 
 systemctl reset-failed ncp-update-nc 2>/dev/null ||:
-systemd-run -u 'ncp-update-nc' bash -c "set -o pipefail; DBG='${DBG:-}' /usr/local/bin/ncp-update-nc.d/update-nc.sh '${VER}' |& tee /var/log/ncp-update-nc.log"
+systemd-run -u 'ncp-update-nc' --service-type=oneshot --no-block -p TimeoutStartSec="24h" -p TimeoutStopSec="1h" \
+  bash -c "set -o pipefail; DBG='${DBG:-}' /usr/local/bin/ncp-update-nc.d/update-nc.sh '${VER}' |& tee /var/log/ncp-update-nc.log"
 sleep 1
 
 if ! [[ "$(systemctl is-active ncp-update-nc ||:)" =~ ^(active|inactive|activating|deactivating)$ ]]