Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes are bigger in preview mode when line contains '☑'-character #654

Closed
1 of 2 tasks
korelstar opened this issue Jan 2, 2020 · 4 comments
Closed
1 of 2 tasks
Labels

Comments

@korelstar
Copy link
Member

korelstar commented Jan 2, 2020

  • The color of the checkboxes is too dark in dark-mode (see screenshot below).
  • On my smartphone (LineageOS 16, Android 9), the checkbox variants "unchecked" and "checked" have different sizes (see screenshot below). However, on my emulator with Android 8, everything is fine.

Screenshot_20200101-142912_Notizen

stefan-niedermann added a commit that referenced this issue Jan 2, 2020
The color of the checkboxes is too dark in dark-mode (see screenshot below).
@stefan-niedermann
Copy link
Member

@korelstar can you attach the exact markdown you are using as a .txt-file or share a pastebin?

I also noticed this, but it happened only at some combinations of headlines, linebreaks and some other stuff - I was never able to reproduce the issue perfectly.

I think this is yet another issue of RxMarkdown and i am not sure whether we can workaround it or not.

@korelstar
Copy link
Member Author

It looks that this happens when there are some special unicode characters in the same line. Here is an example which is reproducable:

- [ ] ☑
- [ ] Test

But it's an edge-case, then. So maybe the time to fix it doesn't worth it.

@stefan-niedermann
Copy link
Member

Nice research. I could imagime that emoji support the font is changed (which could cause higher lines and therefore bigger checkboxes).

@stefan-niedermann stefan-niedermann changed the title checkbox design Checkboxes are bigger in preview mode when line contains '☑'-'character Jan 31, 2020
@stefan-niedermann stefan-niedermann changed the title Checkboxes are bigger in preview mode when line contains '☑'-'character Checkboxes are bigger in preview mode when line contains '☑'-character Jan 31, 2020
@stefan-niedermann
Copy link
Member

stefan-niedermann commented Feb 1, 2020

Well, i think there's not much we can do on our side. Though RxMarkdown seems to be abandoned, i opened an issue (at least for documentation purposes): yydcdut/RxMarkdown#66

I will close this because we will switch the markdown lib or at least fork it (in this case we can rely on the bugs which are already reported and documented in the original repo) in the long term...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants