Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors if Raven is already configured & installed globally #1

Open
ThisIsMissEm opened this issue Sep 24, 2015 · 4 comments
Open

Errors if Raven is already configured & installed globally #1

ThisIsMissEm opened this issue Sep 24, 2015 · 4 comments

Comments

@ThisIsMissEm
Copy link

The call to configure & install Raven should be wrapped:

if (!Raven.isSetup()) {
  // ... configure
}
@ngokevin
Copy link
Owner

@ThisIsMissEm
Copy link
Author

Looks good — One thing I did notice in my testing is that the store/state on sentry errors is meaningless as it can easily become very big — also, sentry truncate this field to 512 bytes or something like that.

@ngokevin
Copy link
Owner

So the error messages transmitted to Sentry become not helpful?

@ThisIsMissEm
Copy link
Author

Yup.

For now I've just gone with sending the action; But something I may do in the future is to have my middleware keep a FIFO list of recent actions, capped at say 10 or 20, and then send that with the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants