Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding workbench.colorCustomizations does not work #67

Open
etienne-dldc opened this issue Oct 6, 2024 · 0 comments
Open

Overriding workbench.colorCustomizations does not work #67

etienne-dldc opened this issue Oct 6, 2024 · 0 comments
Labels
🐛 Bug Something isn't working

Comments

@etienne-dldc
Copy link

Describe the bug

When defining a workbench.colorCustomizations object in slides.vscodeSettings before activating slide mode it does not work.
The default workbench.colorCustomizations from the extension is removed but the custom one is not added...

How to reproduce

Activate the slides mode with this .vscode/settings.json

{
  "slides.vscodeSettings": {
    "workbench.colorCustomizations": {
      "editorCursor.background": "#ffffff",
      "editorCursor.foreground": "#0000bb",
      "editor.lineHighlightBackground": "#0e121b15",
      "editor.selectionBackground": "#aaeeff",
      "editorError.background": "#ff000050",
      "editorError.foreground": "#fe0101",
      "editorError.border": "#fe0101"
    }
  }
}

Expected behavior

The workbench.colorCustomizations defined in slides.vscodeSettings should be in the slide mode.

Additional information

  • Version of the extension impacted: _ v4.2.1_
@etienne-dldc etienne-dldc added the 🐛 Bug Something isn't working label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant