-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
most likely missing word in the card overview #875
Comments
The translations of the card are provided by users , I don’t speak German so I have no idea what is correct.
The {days} part will be replaced with the selected range of days. Could you explain in which way this line has to be corrected? |
oh sorry, Once again but in english: Here are 2 examples where the second one shows the issues cause there are 2 cases to check based on what has been selected in case of CUSTOM / AUSWÄHLEN Expected behavior"Jeden = EVERY" makes sense if some but not all days have been selected In case EVERY day has been selected there are 2 options in my opinion, a shorter one and a longer one "Monday till Sunday " Actual behavior"EVERY from Monday till Sunday" is not right in this particular case where every day has been selected. but "every from M till S" makes no sense. In my opinion it is not a translation issue Steps to Reproduceas seen in the screenshot I had chosen "CUSTOMS / AUSWÄHLEN" and selected every weekday great solution - really missed for many years cause I did not know about it till I saw a german youtuber explaining this solution partially this week which has been released 6 or 9 months ago, but was not getting into the details. |
Here is the german part
the first means "every monday, ...." but "days range" cause the issue cause in case of every day you are using most likely this combination of
this creates "every" and then "repeated_days" or "every from {startDay} till {endDay}" As said before in such case with all days selected in english and german this should work but every from monday till sunday is not really working in english or german and most likely other languages too Your are combining these 2 options "repeated_days" and "days_range" which the translator have not seen. I bet it has started "from {startDay} till {endDay}" Every from {startDay} till {endDay} I hope it helps. Off Topic: Is there anywhere a switch to turn the automatic first uppcase letter of cause the german translations you had given me the link to is written in lower case and it is right . Thansk a lot |
I opened a pull request based on your changes This makes it easier to see all modifications and make further improvements to it if required. The file contains 248 lines, while yours is 247 lines. I don't know what is missing (this would have to be checked manually). |
I am also seeing this error message when processing your file:
|
I will check that later when I have more time. But here is what I have done. Later I found out "others" , this whole set of configuration , which had been missing on my german one. And then I found out that this english file has been longer and so I tried my best to copy the part which had been missing. But I will check that out in notepad and compare those 2. Is there any other way for me to check that file out on my local system before I send it to you ? Thanks a lot for your patience. |
Here are 2 examples where the second one shows the issues cause there are 2 cases to check based on what has been selected in case of CUSTOM / AUSWÄHLEN
Checklist
Expected behavior
"Jeden" makes sense if some but not all days have been selected
And in case every day has been selected there are 2 options in my opinion, a shorter one and a longer one
"Montag bis Sonntag"
or longer
"Jeden Montag bis Sonntag"
Actual behavior
"Jeden von Montag bis Sonntag" is not right in this particular case where every day has been selected.
Steps to Reproduce
as seen in the screenshot I had chosen "AUSWÄHLEN" and selected every weekday
great solution - really missed for many years cause I did not know about it till I saw a german youtuber explaining this solution partially this week which has been released 6 or 9 months ago, but was not getting into the details.
The text was updated successfully, but these errors were encountered: