Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine chproxy and clickhouse-bulk #20

Open
yang3808282 opened this issue Nov 14, 2019 · 8 comments
Open

combine chproxy and clickhouse-bulk #20

yang3808282 opened this issue Nov 14, 2019 · 8 comments

Comments

@yang3808282
Copy link

I want to add bulk features to chproxy,can you help me how to do it?

@nikepan
Copy link
Owner

nikepan commented Nov 14, 2019

How I can help you? You want import clickhouse-bulk as module or implement this functionality?

@yang3808282
Copy link
Author

How I can help you? You want import clickhouse-bulk as module or implement this functionality?

thanks for your reply, I want to implement this functionality

@nikepan
Copy link
Owner

nikepan commented Nov 14, 2019

As example, you can add bulk before chproxy

@asfaltboy
Copy link

I have a different package and I'd love to import clickhouse-bulk to do exactly the same (while kipping the interface slim). Would you be interested in that sort of refactoring, and consider a PR perhaps?

@nikepan
Copy link
Owner

nikepan commented Feb 5, 2020

What do you want to change? Can you send pr or needed changes?

@nikepan
Copy link
Owner

nikepan commented Feb 5, 2020

Возможно стоит по русски) У меня сейчас не особо много времени делать какой-то большой объем работе. Но если изменения небольшие, могу сделать. Если что-то большое, то надо смотреть, что нужно.

@asfaltboy
Copy link

Basically I wanted a plug and play solution to use to batch up calls the client, e.g via https://github.com/mailru/dbr .

I ended basically mimicking the collector.go module, collecting and doing batch insertions of records instead of generating the query text. The solution is quite a bit shorter, but not very generalized (my "Table.Rows"field is a slice of my "ClickhouseRow" struct).

Do you think something like that has place in clickbouse-bulk?

@nikepan
Copy link
Owner

nikepan commented Feb 7, 2020

I think that such solutions are quite private. And yet I do not understand what should result? It seems to me that collecting requests from structures is much faster than processing it with a parser in collector.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants