Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to support protobuf editions #677

Open
zwing99 opened this issue Feb 6, 2025 · 3 comments
Open

update to support protobuf editions #677

zwing99 opened this issue Feb 6, 2025 · 3 comments

Comments

@zwing99
Copy link

zwing99 commented Feb 6, 2025

edition = "2023";

message TestContract {
    string id = 1;
    string name_of_person = 2;
    int32 age = 3;
}

using the contract above i get this warning:

test_contracts.proto: is an editions file, but code generator protoc-gen-mypy hasn't been updated to support editions yet. Please ask the owner of this code generator to add support or switch back to proto2/proto3.

Editions seems like the go forward for protobuf and mypy is certainly the go forward for python. Any chance this tooling can be updated to support it?

@wbhob
Copy link

wbhob commented Feb 27, 2025

+1 on this. Editions are the future of Protobuf, will be very helpful to have this for strong types.

@nipunn1313
Copy link
Owner

yep seems reasonable! I've definitely been a bit behind in doing updates.

Let me catch some time in between things at my startup. Bear with me.

@wbhob
Copy link

wbhob commented Feb 27, 2025

Thank you — as a note, I was able to get up and running with the official protocolbuffers/pyi package. They may have a reference implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants