allow run jobs in parallel (#13) #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AeroNotix
force-pushed
the
feat/parallel
branch
from
8227bb0 to
5af2085
Compare
AeroNotix
force-pushed
the
feat/parallel
branch
from
6979952 to
4d4067b
Compare
jasonkarns
reviewed
Aug 17, 2020
jasonkarns
reviewed
Aug 17, 2020
jasonkarns
reviewed
Aug 17, 2020
jasonkarns
reviewed
Aug 17, 2020
jasonkarns
reviewed
Aug 17, 2020
jasonkarns
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Overall looks great!
Normally at this point I'd say "needs tests", but this plugin doesn't already have a test suite :sad: so I'm not going to but its creation on you. 😸
However, without tests, I'll need to do some more manual checking before we proceed. But I'm excited for this feature, thank you!
|
@jasonkarns interested in hearing your feedback. I took care of the issues you raised |
1 similar comment
|
@jasonkarns interested in hearing your feedback. I took care of the issues you raised |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13