Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: limit the scope of IAM instance policy #100

Open
vaijab opened this issue Jul 21, 2017 · 1 comment
Open

aws: limit the scope of IAM instance policy #100

vaijab opened this issue Jul 21, 2017 · 1 comment

Comments

@vaijab
Copy link
Contributor

vaijab commented Jul 21, 2017

Current AWS implementation allows for compute and master nodes to manage pretty much all EC2 resources across AWS account, see:
https://github.com/UKHomeOffice/keto/blob/master/pkg/cloudprovider/providers/aws/cloudformation_templates.go#L356
https://github.com/UKHomeOffice/keto/blob/master/pkg/cloudprovider/providers/aws/cloudformation_templates.go#L533

compute nodes

  • should only be able to describe their own tags. I cannot think of anything else that they need?

master nodes

  • whatever kubernetes requires
  • should be able to set tags on compute nodes as part of the same cluster
@jon-shanks
Copy link

Makes sense to me , we definitely should limit the compute nodes. Would be good to limit the master but less of a security risk to a degree but probably worth investing the effort in both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants