Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Replace Faraday with Httparty #31

Closed
Tracked by #421
jeremyf opened this issue May 25, 2023 · 0 comments · Fixed by #32
Closed
Tracked by #421

♻️ Replace Faraday with Httparty #31

jeremyf opened this issue May 25, 2023 · 0 comments · Fixed by #32

Comments

@jeremyf
Copy link
Contributor

jeremyf commented May 25, 2023

Many versions of Valkyrie and ActiveFedora have Faraday ~> 0.9 type
dependencies whereas the Faraday redirect middleware requires Faraday ~> 1.0
or some such thing.

This is a complex dependency update. So instead we should replace Faraday with
Httparty.

Related to:
@jeremyf jeremyf mentioned this issue May 10, 2024
Open
37 tasks
jeremyf added a commit that referenced this issue May 25, 2023
@jeremyf
♻️ Replacing Faraday with Httparty
9c33933 
> Many versions of Valkyrie and ActiveFedora have Faraday `~> 0.9` type
> dependencies whereas the Faraday redirect middleware requires Faraday
> `~> 1.0` or some such thing.

Updating Valkyrie and ActiveFedora's different branches and versions to
later Faraday versions.

Closes #31

- #31
@jeremyf jeremyf mentioned this issue May 25, 2023
Merged
jeremyf added a commit that referenced this issue May 25, 2023
@jeremyf
♻️ Replacing Faraday with Httparty
05a36bd 
> Many versions of Valkyrie and ActiveFedora have Faraday `~> 0.9` type
> dependencies whereas the Faraday redirect middleware requires Faraday
> `~> 1.0` or some such thing.

Updating Valkyrie and ActiveFedora's different branches and versions to
later Faraday versions.

Closes #31

- #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ Replacing Faraday with Httparty notch8/derivative_rodeo
1 participant
@jeremyf