-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previously PDF.js => UV resplit is not working #239
Comments
This commit will add a fix for re-splitting PDFs, the problem was because of keyword arguments. Ref: - notch8/palni_palci_knapsack#239
pulls in the following issues from hyku: - #239 - notch8/palni-palci#1019 - #194 - #240
QA RESULTS: ❌ Needs Reworktested on STAGING I clicked the resplit button but no jobs spawn. Additionally when I re checked the work I expected to see the child works deleted but that never happened and it looks like this could has been deployed to staging. ![]() |
Update: maybe this line is returning false for this tenant? I'll confirm in staging.
Udpate 2: IiifPrint::TenantConfig.use_iiif_print? => true for this tenant so the code should've continued. Update 3: this is working for me locally so now I'm wondering again if this code has been deployed 🤔 |
QA RESULTS: ✅ ⚠ PASS (previously imported pdfs [pdf.js] can be split after enabling [UV] and clicking re split)tested on STAGING I retested this on the demo tenant and it's working. Perhaps something else is going on with the tenant referenced in the description. ⚠ Since April is transferring staging to a new cluster, we will likely lose access to the referenced tenant for further investigation so I'd recommend reopening this if it happens again. |
More on au-archives debugging: Calling the resplit job returned => :no_pdfs_for_splitting
this issue is happening because the file path doesn't end with .pdf 🤔 why? I'm tempted to try re uploading this file but should't have to
|
Summary
This work was previously imported using PDF.js. When we ReSplit, nothing seems to happen (splits and no child work attachments)
https://au-archives.palni-palci-staging.notch8.cloud/concern/generic_works/97025525-7b7f-40a3-a40d-a2041445b5b0?locale=en#
related
Acceptance Criteria
Screenshots or Video
I was able to reproduce this from Hyku main -
Testing Instructions
🚧 🛑 Resplitting will create valkyrie child works. If done on a work that is NOT valkyrie, it will fail to index correctly.
Until works are migrated to valkyrie, the work should be edited and saved (even without changes) which will migrate it to Valkyrie. Then you can safely use the resplit option.
Notes
The text was updated successfully, but these errors were encountered: