This repository has been archived by the owner on Mar 20, 2020. It is now read-only.
Rails 5 #2
Open
Rails 5 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent with other index parts
ghost
requested a review
from 
jmks
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
I like the changes to the test infrastructure.
The Rails monkey patches roughly look how I remember them.
I never found a good way to test the differences between Rails versions, but I think your approach of ENV vars is understandable. TravisCI helped a bit with that on another gem, but it appears I never fully set it up in this one.
Thanks!
ghost
closed this
|
Leaving this branch unmerged as part of the Rails 5 upgrade. The app will point to the Rails 5 branch of this gem. |
ghost
reopened this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.