Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio settings optimized for music #87

Open
ojack opened this issue Mar 30, 2020 · 2 comments
Open

Audio settings optimized for music #87

ojack opened this issue Mar 30, 2020 · 2 comments

Comments

@ojack
Copy link
Owner

ojack commented Mar 30, 2020

Settings that seem helpful for working on music:
noiseSuppression: false,
echoCancellation: false,
autoGainControl: false

More explanation of available contraints at https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API/Constraints and https://mdn.mozillademos.org/en-US/docs/Web/API/Media_Streams_API/Constraints$samples/Example_Constraint_exerciser?revision=1588638&fbclid=IwAR1ZIbQIayqO6TIBzLjSNSS_FRjwYvVrSOR4HtwE1DjYkDgzOtZrrFCQjls

Questions:

  • What should the UI for this be like? Controls of specific settings and/or way to specifiy 'optimize for music' vs 'optimize for chat'
@ojack
Copy link
Owner Author

ojack commented Mar 31, 2020

Tagging @colinbdclark in case you have insights :)

@colinbdclark
Copy link
Contributor

Hi @ojack, thanks for tagging me. I'm so glad you've had a chance to look into this, thanks!

I think the best scenario for the UI might involve a set of checkboxes for the individual controls, along with a "presets" drop box that would allow a user to quickly choose between "Voice", "Music", and "Custom." Does that seem doable? Let me know if I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants