Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the error message why it has failed or at least show the pipeline URL just like running locally #17

Open
kkweon opened this issue Sep 22, 2021 · 10 comments

Comments

@kkweon
Copy link

kkweon commented Sep 22, 2021

I'm also seeing the same error message as in #14, but the thing is that error message doesn't help.

It simply says

failed to deploy pipeline: failed to deploy okteto pipeline

It doesn't say why it has failed.

image

Could it be perhaps updated to show an actual error message? Or show the pipeline URL just like running locally.

In my case, I can successfully run okteto pipeline deploy but in GitHub Actions, I get the error message and I'm still not sure what's going on (it used to work in the past months, and suddenly stopped working yesterday).

@pchico83
Copy link
Contributor

@kkweon could you try to set the name field of the github action. It should mandatory

@kkweon
Copy link
Author

kkweon commented Sep 22, 2021

https://github.com/codingpot/pr12er/runs/3671096358?check_suite_focus=true

That was the first thing i tried but didn't work.

The name is not required unlike its description. I've been using without a name for several months already. That's another bug too.

@pchico83
Copy link
Contributor

In the logs it says:

okteto pipeline deploy --name push- '--branch=main'

I don't think it is getting the name parameter properly.
Could you point to your github action?

@kkweon
Copy link
Author

kkweon commented Sep 22, 2021

push- is the name

https://github.com/codingpot/pr12er/actions/runs/1260313992/workflow

      - uses: okteto/pipeline@master
        with:
          name: push-${{ github.event.number }}

it's just the event number didn't get propagated because i triggered manually.

@pchico83
Copy link
Contributor

Oh, I see. Did you try when it runs automatically? I think it is going to work

@kkweon
Copy link
Author

kkweon commented Sep 22, 2021

I'm pretty positive that it wouldn't work.
Could you explain ? name is set, and it didn't work.

@kkweon
Copy link
Author

kkweon commented Sep 22, 2021

Just to be clear, the issue here is about an error message rather than debugging my issue (which will be resolved naturally if there's a clear error message).

@pchico83
Copy link
Contributor

push- is not a valid name. push-nnn is a valid name. that should unblock you.
But yes, leave the issue opened, the error should be clearer

@kkweon
Copy link
Author

kkweon commented Sep 22, 2021

thank you. it indeed resolve the issue.

is there a documentation on what a valid name is? if not, that would be the second feature request.

@pchico83
Copy link
Contributor

We will add it to the docs, but they have the same restrictions than kubernetes labels:
https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants