Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid type _FixedFindCallerLogger for attribute '_logger' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types #4401

Open
folt opened this issue Jan 29, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@folt
Copy link

folt commented Jan 29, 2025

Describe your environment

python = "^3.11"

opentelemetry-api = "^1.29.0"
opentelemetry-sdk = "^1.29.0"
opentelemetry-distro = {extras = ["otlp"], version = "^0.50b0"}
opentelemetry-instrumentation = "^0.50b0"
opentelemetry-semantic-conventions = "^0.50b0"

What happened?

fix #3649

I get the same multiple logs. This significantly increases the size of my logs. I use structlog + open-telemetry.
Maybe it's worth creating customizable log attribute filters via the environment that would do the DROP_ATTRIBUTES logic from the example above?

Steps to Reproduce

Use opentelemetry-python + structlog

Expected Result

Logs come without repetitions

Actual Result

As a result, we get a large volume of logs with repeating content

Additional context

No response

Would you like to implement a fix?

None

@folt folt added the bug Something isn't working label Jan 29, 2025
@roger-collins-self
Copy link

I've already done the work for this in my fork - the fix is extremely simple.

However, according to discussion other issues here around logging, it seems that there's a consensus that the SDK project shouldn't be accommodating other logging libraries.

I'll gladly make a PR with the fix if we can make a small exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants