Update LogRecord batching processor behavior description #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cijothomas
reviewed
Feb 10, 2025
…scription of maxExportBatchSize consistent with Trace for clarity
Hopefully soon yes, waiting on it. |
pellared
reviewed
Feb 14, 2025
…ded for previous format then not cleaned up correctly)
…cation into issue-4402
pellared
approved these changes
Feb 14, 2025
pellared
changed the title
pellared
added
area:sdk
|
Please also update the PR description as it is outdated. |
reyang
reviewed
Feb 14, 2025
Comment on lines
+427
to
+428
| - `scheduledDelayMillis` after the processor is constructed OR the first `LogRecord` | ||
| is received by the log record processor. |
There was a problem hiding this comment.
Why would we want to have the 2nd part? Asking this question more coming from "why do we want to have complex rules instead of simple rules".
- the first
LogRecordis received by the log record processor.
cijothomas
reviewed
Feb 14, 2025
| The processor SHOULD export a batch when any of the following happens AND the | ||
| previous export call has returned: | ||
|
|
||
| - `scheduledDelayMillis` after the processor is constructed OR the first `LogRecord` |
There was a problem hiding this comment.
the first
LogRecord
is received by the log record processor.
Why export when first record is received 🤔 ?
There was a problem hiding this comment.
I think that the original author meant "delay after first record'. Probably this could be clarified, but I do not feel it has to be done in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4402
Changes
maxExportBatchSizeto provide more information.Shutdown is calledguidance in Trace and Logs.