EWPP-4910: Prevent crash on release update hooks. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
force-pushed
the
EWPP-4910-2
branch
2 times, most recently
from
7859bd8 to
36a7ae3
Compare
nagyad
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
It seems that some sites load services that in their constructor end up calling in the stack trace a user load. And this causes the container to crash because the new user field doesn't exist (user__field_oe_ldap_groups).
This is very difficult to reproduce, the only way I managed was to add to the constructor of a random service, a User::loadMultiple(). But not just any service. I tried with ExternalAuth where it was fine. But then in DatabaseLockBackend it crashed. I think it may happen only in cases in which the service in question is a dependency of another service.