Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Props need to be relaxed #132

Open
landonreed opened this issue May 19, 2020 · 0 comments
Open

Required Props need to be relaxed #132

landonreed opened this issue May 19, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@landonreed
Copy link
Member

The props API is a little needy. We should be defining noops for functions that are not necessarily required. Also, below this, the location defaultProp is set to undefined. Not really sure that's necessary.

Endpoint.propTypes = {
clearLocation: PropTypes.func.isRequired,
forgetPlace: PropTypes.func.isRequired,
location: locationType,
locations: PropTypes.arrayOf(locationType).isRequired,
MapMarkerIcon: PropTypes.elementType.isRequired,
rememberPlace: PropTypes.func.isRequired,
setLocation: PropTypes.func.isRequired,
showUserSettings: PropTypes.bool.isRequired,
type: PropTypes.string.isRequired
};
Endpoint.defaultProps = {
location: undefined
};

@landonreed landonreed added the bug Something isn't working label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant