Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdown): apply w3c WAI-ARIA (a11y) "combobox" pattern #1143

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat(dropdown): apply w3c WAI-ARIA (a11y) "combobox" pattern #1143

wants to merge 11 commits into from

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Dec 6, 2024 •
edited
Loading

Fixes #1115

Proposed Changes

  • Move some functionality from the Autocomplete component to the Dropdown component
  • Specifiy Dropdown as menu role when not selectable
  • Implement w3c WAI-ARIA (a11y) Combobox pattern in Dropdown component when selectable
    • Update aria and role attributes
    • Update keybinds
    • Add selectable prop to specify behaviour
  • Update dropdown dependent Autocomplete, Taginput, Datepicker, TimePicker component
  • Updated documentation

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Dec 6, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

❌ Deploy Preview for oruga-documentation-preview failed.

Name Link
🔨 Latest commit 3c53fb8
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6761a0467fc68d000875ab32

@mlmoravek mlmoravek added the a11y Accessibility label Dec 6, 2024
@mlmoravek mlmoravek changed the title feat(dropdown): add a11y features feat(dropdown): apply w3c WAI-ARIA (a11y) "combobox" pattern Dec 9, 2024
@mlmoravek mlmoravek marked this pull request as ready for review December 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a11y Accessibility breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A11y Dropdown keyboard issue
1 participant
@mlmoravek