internal/cloud/gcp/compute: Add TDX_CAPABLE guest OS feature #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest RHEL images (from 9.6 on) should be able to run as TDX guests. CentOS guests also fully support it at the moment. See: https://issues.redhat.com/browse/COS-3111 See: coreos/coreos-assembler#4006 See: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/5979
bgartzi
force-pushed
the
gcp-tdx_capable
branch
from
614af9b to
ecf5ef5
Compare
|
Hi @thozza, @ondrejbudai, based on other similar PRs I think you could provide some feedback about this. Would any of you mind having a look? |
thozza
reviewed
Feb 13, 2025
Comment on lines
+35
to
+37
| // Guest OS Features for RHEL9.2 images. | ||
| // The TDX support was added since RHEL-9.6. | ||
| var GuestOsFeaturesRHEL92 []*computepb.GuestOsFeature = []*computepb.GuestOsFeature{ |
There was a problem hiding this comment.
Nitpick: I think that the comment should state for RHEL images up to 9.5 and I'd suggest to also name the variable GuestOsFeaturesRHEL95
thozza
requested review from
a team,
mvo5,
achilleas-k and
thozza
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest RHEL images (from 9.6 on) should fully support running as TDX guests, as well as latest CentOS images.
See: https://issues.redhat.com/browse/COS-3111
See: coreos/coreos-assembler#4006
See: https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/5979
This pull request includes:
I couldn't find anything relevant to be changed to address the points above.