Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is not recommended to overwrite font and style in theme files #50

Open
alexandra-c opened this issue Jan 11, 2021 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@alexandra-c
Copy link
Collaborator

alexandra-c commented Jan 11, 2021

We should not overwrite styles. There is a defaultFont object that should be used in all the components we want to. In this way we will keep the Font and Style information in one place.

input: {
fontFamily: "Source Sans Pro !important",
fontSize: "14px !important",
fontWeight: "normal !important",
fontStretch: "normal !important",
fontStyle: "normal !important",
lineHeight: "1.29 !important",
color: "#a8a8a8 !important"

The above code should be removed, especially the !Important attribute and fix the issue. If you needed to use !Important it means that someone is overriding these theme configs and in this case you must figure out where that happens and make sure it uses the defaultFont object instead.

@alexandra-c alexandra-c added the bug Something isn't working label Jan 11, 2021
@VCuzmin VCuzmin self-assigned this Feb 5, 2021
@VCuzmin
Copy link
Contributor

VCuzmin commented Mar 18, 2021

@alexandra-c ma poti ajuta cu asta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants