Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps with "gulag" as server enum are unexpectedly deleted #244

Open
def750 opened this issue Jun 19, 2022 · 7 comments
Open

Maps with "gulag" as server enum are unexpectedly deleted #244

def750 opened this issue Jun 19, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@def750
Copy link
Contributor

def750 commented Jun 19, 2022

Maps with server 'gulag' get deleted from database (I tried in few different ways to stop this but only idea I had was wayyy to slow)

@juup1ter
Copy link

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

@def750
Copy link
Contributor Author

def750 commented Jun 19, 2022

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

@juup1ter
Copy link

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

i guess this is per map basis then. i have a couple of maps i have deleted on bancho but are still ranked, about 2 weeks later.

@def750
Copy link
Contributor Author

def750 commented Jun 19, 2022

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

i guess this is per map basis then. i have a couple of maps i have deleted on bancho but are still ranked, about 2 weeks later.

Maybe, idk but happened to around 8 maps on my server already where I had scores

@tsunyoku
Copy link
Contributor

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

this is intentional. freezing is to preserve statuses from updates, not make it immune from being unsubmitted. supporting unsubmitted maps is never going to work in a stable way - if the .osu file accidentally gets deleted or the db row get's messed up, there's no going back. and that's when you start to get api/lb errors

@cmyui
Copy link
Member

cmyui commented Jul 24, 2022

Hey @def750 the 1st point is intended behaviour and won't be fixed

as for 2nd - is this issue specifically with qualified maps? or does this apply to all maps? is it only the ranked status not being updated, or all fields?

as for 3rd i'll have to investigate - were you trying to implement beatmap submission? also, could you split this into another issue so we can just focus this issue on the 2nd?

thanks! and sorry for the late reply 🥲

@cmyui cmyui added the bug Something isn't working label Jul 24, 2022
@cmyui cmyui changed the title Issues with map freezing Unfrozen maps status not updating; maps from "gulag" server get deleted Jul 24, 2022
@cmyui cmyui self-assigned this Jul 24, 2022
@tsunyoku
Copy link
Contributor

first issue exists at #420 but second issue is still something with little info or predictability so i'm just gonna rename this issue for that specifically

@tsunyoku tsunyoku changed the title Unfrozen maps status not updating; maps from "gulag" server get deleted Maps with "gulag" as server enum are unexpectedly deleted Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants