Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange case of marks #122

Open
arademaker opened this issue Jul 10, 2019 · 9 comments
Open

strange case of marks #122

arademaker opened this issue Jul 10, 2019 · 9 comments

Comments

@arademaker
Copy link
Member

image

why dark-brown has the superscript JJ1?

@arademaker
Copy link
Member Author

It should be a1 as other single word tokens?

@arademaker
Copy link
Member Author

why MWE does not follow the presentation of single tokens that, once annotated, have the superscript on the right with pos+buffer-sense where buffer-sense is a single-digited sense in the buffer.

odanoburu added a commit that referenced this issue Jul 10, 2019
@odanoburu
Copy link
Contributor

does 3144dc1 fix the problem?

although I made it show s1 as it's an adjective satellite; or do you think we should collapse it to adjective? (I guess annotation-wise it makes more sense, as satellites are not a real PoS..)

why MWE does not follow the presentation of single tokens that, once annotated, have the superscript on the right with pos+buffer-sense where buffer-sense is a single-digited sense in the buffer.

not sure I understand what you mean, but could it be that the problem is that dark brown is a glob, but dark-brown is not?

@odanoburu
Copy link
Contributor

can I close this, @arademaker ?

@arademaker
Copy link
Member Author

arademaker commented Aug 16, 2019

No. In the buffer any@dark-brown the superscripts are only numbers. In

(n) anthophyllite | a dark brown mineral of the amphibole group ; magnesium iron silicate ;

the glob drak-brown should have the superscript a1. My point is why dark-brown has superscript s1 (should be a1) but the glob only a number without the PoS?

Yep, our PoS should be only : n, a, r, v

odanoburu added a commit that referenced this issue Aug 16, 2019
@odanoburu
Copy link
Contributor

this should be fixed now in dev by 4b168e2

@arademaker
Copy link
Member Author

this fixes the code in dev branch, right?

@odanoburu
Copy link
Contributor

fd2f538 fixes it in master too.

@odanoburu odanoburu reopened this Aug 16, 2019
@odanoburu
Copy link
Contributor

odanoburu commented Aug 16, 2019

  • must show PoS of globs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants