Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fonts into our Theme mechanism #161

Open
pablocarmu opened this issue Nov 19, 2018 · 0 comments
Open

Add fonts into our Theme mechanism #161

pablocarmu opened this issue Nov 19, 2018 · 0 comments
Labels
p4-low Low priority

Comments

@pablocarmu
Copy link
Contributor

We've discussed a couple of times about adding font support to our theme mechanism.
Like with colors, using the existing theme mechanism we can have a centralized mechanism to call when a required font and font size is needed. This way our app can be more consistent.

The API call could be something like:

ThemeCollection.navigationFonts.barButtonFont.normal
ThemeCollection.navigationFonts.barButtonFont.highlighted

ThemeCollection.buttonFonts.normal
ThemeCollection.buttonFonts.highlighted

@mneuwert @felix-schwarz what are your thought about this?
@pablocarmu pablocarmu mentioned this issue Nov 19, 2018
Merged
9 tasks
@pablocarmu pablocarmu changed the title Add fonts into our Theme mechanim Add fonts into our Theme mechanism Nov 20, 2018
@michaelstingl michaelstingl added the p4-low Low priority label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelstingl @pablocarmu