Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

napi/transformer: improve diagnostics #6158

Open
3 tasks
Boshen opened this issue Sep 29, 2024 · 2 comments
Open
3 tasks

napi/transformer: improve diagnostics #6158

Boshen opened this issue Sep 29, 2024 · 2 comments
Assignees
Labels
C-enhancement Category - New feature or request

Comments

@Boshen
Copy link
Member

Boshen commented Sep 29, 2024

TS(17019)

  x '!' at the end of a type is not valid TypeScript syntax.
   ,-[asdf.tsx:1:8]
 1 | let x: asdf!
   :        ^^^^^
   `----
  help: Did you mean to write 'asdf'?
  • something is missing before the , it's a separator.
  • TS(17019) looks weird
  • Need structured output so other tools can have the opportunity to display their own code frame
@Boshen Boshen added the C-enhancement Category - New feature or request label Sep 29, 2024
@Boshen Boshen self-assigned this Sep 29, 2024
@Boshen
Copy link
Member Author

Boshen commented Sep 29, 2024

We are currently using miette with a forked graphical reporter, I think it's time to fork and consolidate things ...

@DonIsaac
Copy link
Collaborator

DonIsaac commented Oct 2, 2024

Ive been working on this, I can take it on if needed

@Boshen Boshen assigned DonIsaac and unassigned Boshen Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants