Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched react-day-picker dep in @blueprintjs/[email protected] breaking app-level installs #7172

Closed
amcclain opened this issue Jan 14, 2025 · 4 comments

Comments

@amcclain
Copy link

amcclain commented Jan 14, 2025

Environment

  • Package version(s): @blueprintjs/datetime 5.3.20
  • Operating System: MacOS
  • Browser name and version: N/A (dependency install / build issue)

Code Sandbox

N/A

Steps to reproduce

  1. Spec latest @blueprintjs/datetime or @blueprintjs/datetime2 as a dependency for your project
  2. Run yarn install (or in our case yarn upgrade, taking this latest version) with yarn v1

Actual behavior

Install fails with

Couldn't find any versions for "react-day-picker" that matches "patch:react-day-picker@npm%3A7.4.9#~/.yarn/patches/react-day-picker-npm-7.4.9-8853eff118.patch"

Patched dependency coming from @blueprintjs/datetime (a transitive dep of datetime2):

"react-day-picker": "patch:react-day-picker@npm%3A7.4.9#~/.yarn/patches/react-day-picker-npm-7.4.9-8853eff118.patch",

Expected behavior

Library + transitive dependencies install successfully, as with prior versions.

Possible solution

Change introduced in #7146. I'm not too familiar with the yarn patch syntax, but from a brief look it's a) only supported by yarn2 and b) would require the patch file to be distributed, which it is not.

Did you intend to release this? Apologies if I am missing something here regarding package manager requirements, etc.

amcclain added a commit to xh/toolbox that referenced this issue Jan 14, 2025
- See palantir/blueprint#7172 - checking with BP team to see if release of transitive dep on react-day-picker with patch spec was intentional
@ggdouglas
Copy link
Contributor

ggdouglas commented Jan 15, 2025

Hey @amcclain , thanks for filing! This definitely wasn't intentional to have this break. We'll revert the patched change and cut a new release shortly.

@ggdouglas
Copy link
Contributor

We've cut a new release that removes the patched react-day-picker dependency. Thanks for bearing with us!

@amcclain
Copy link
Author

Much appreciated - thank you for flipping a new release right around - really appreciate the library 👍👍

@ggdouglas
Copy link
Contributor

This is resolved in release @blueprintjs/[email protected] & @blueprintjs/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants