-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patched react-day-picker
dep in @blueprintjs/[email protected]
breaking app-level installs
#7172
Comments
- See palantir/blueprint#7172 - checking with BP team to see if release of transitive dep on react-day-picker with patch spec was intentional
Hey @amcclain , thanks for filing! This definitely wasn't intentional to have this break. We'll revert the patched change and cut a new release shortly. |
We've cut a new release that removes the patched |
Much appreciated - thank you for flipping a new release right around - really appreciate the library 👍👍 |
This is resolved in release |
Environment
Code Sandbox
N/A
Steps to reproduce
@blueprintjs/datetime
or@blueprintjs/datetime2
as a dependency for your projectyarn install
(or in our caseyarn upgrade
, taking this latest version) with yarn v1Actual behavior
Install fails with
Patched dependency coming from
@blueprintjs/datetime
(a transitive dep of datetime2):blueprint/packages/datetime/package.json
Line 49 in 127e5af
Expected behavior
Library + transitive dependencies install successfully, as with prior versions.
Possible solution
Change introduced in #7146. I'm not too familiar with the yarn patch syntax, but from a brief look it's a) only supported by yarn2 and b) would require the patch file to be distributed, which it is not.
Did you intend to release this? Apologies if I am missing something here regarding package manager requirements, etc.
The text was updated successfully, but these errors were encountered: