Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: low Contrast issue #60041

Open
1 task done
MR-Elbarbary opened this issue Oct 14, 2024 · 2 comments
Open
1 task done

DOC: low Contrast issue #60041

MR-Elbarbary opened this issue Oct 14, 2024 · 2 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Docs Duplicate Report Duplicate issue or pull request

Comments

@MR-Elbarbary
Copy link

MR-Elbarbary commented Oct 14, 2024

Pandas version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Location of the documentation

https://pandas.pydata.org/docs/getting_started/index.html#intro-to-pandas

Documentation problem

here in dark mode,
the text has low contrast issue, it's hard to read the test
image

Suggested fix for documentation

<div class="d-flex flex-row tutorial-card-header-2" bis_skin_checked="1">
<button class="btn btn-dark btn-sm"></button>
What kind of data does pandas handle?
</div>

making the text color "What kind of data does pandas handle" white or any other bright color to increase the contrast
my changing the css color to white,
If you accept to fix this issue let me fix it (it will be my first PR)

@MR-Elbarbary MR-Elbarbary added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 14, 2024
@asishm
Copy link
Contributor

asishm commented Oct 14, 2024

Thanks for the report. There's already an open issue present - see #60024

@asishm asishm added Closing Candidate May be closeable, needs more eyeballs Duplicate Report Duplicate issue or pull request and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 14, 2024
@easternsun7
Copy link

Maybe take a look at this PR: Update getting_started.css #60027, this was resolved in both dev and 2.1 versions, so it seems that this task doesn't need to be discussed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closing Candidate May be closeable, needs more eyeballs Docs Duplicate Report Duplicate issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants