Bug: fix Concatenating dataframe and series with ignore_index = True #60983
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew Roeschke <[email protected]>
Anurag-Varma
commented
Feb 23, 2025
Comment on lines
+346
to
+350
| expected = DataFrame( | ||
| np.kron(np.where(np.identity(3) == 1, 1, np.nan), arr).T, | ||
| index=np.arange(30, dtype=np.int64), | ||
| columns=["foo", 0, "bar"], | ||
| ) |
There was a problem hiding this comment.
Previous expected DataFrame is incorrect. It then had only 1 column instead of 3 as all their names were getting replaced by 0 and so were merged into 1 column with name 0.
Now changed the code with this PR, so each column will have its previous name and wont get replaced by name 0.
|
Hi @rhshadrach Requesting a review as no reviewer is assigned to the PR Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore_index = Truedrops the series name #60723 and BUG:pd.concaton axis "index" has unexpected result concatenating Series and DataFrame with same (column) name #56257doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.